Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(package): require React 16.3 #3032

Merged
merged 26 commits into from
Oct 24, 2018
Merged

BREAKING(package): require React 16.3 #3032

merged 26 commits into from
Oct 24, 2018

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jul 23, 2018 •
edited
Loading

BREAKING CHANGES

1. Require React 16.3

In future PRs we will heavily rely on the React's forwardRef API, this means that we will require React 16.3, #2844.

This will also allow us to use new React lifecycle hooks and prepare for future deprecations, #2732.

2. Transition.Group use React.Fragment as default as

Now we can omit useless div by default, see #3030 for more details. react-transition-group has same options.

Non-breaking

  1. AccordionPanel now uses React.Fragment
  2. Portal now uses React.Fragment

Oleksandr Fediashov added 2 commits July 23, 2018 11:53
braking(package): use React 16.3
168eb49 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
feat(Transition): set React.Fragment as default for Transition.Group
6bc872a 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
@layershifter layershifter mentioned this pull request Jul 23, 2018
Closed
Oleksandr Fediashov and others added 12 commits July 25, 2018 11:56
Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…
5e29dff 
…React into react-16.3

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

# Conflicts:
#	package.json
#	yarn.lock
update yarn.lock
506f289 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
chore(Portal): use React.Fragment
e94816a 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
chore(Accordion): use React.Fragment in AccordionPanel
a729dba 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
test(Transition): fix broken tests
fc83d03 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
fix(package): fix @types/react in yarn
30d0778 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
@layershifter
Merge branch 'master' into react-16.3
07adf2f
Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…
f5d940c 
…React into react-16.3
test(common): fix broken test
2f8b566 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
fix(docs): fix path separator
5a63042 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
Merge branch 'react-16.3' of https://github.com/Semantic-Org/Semantic…
e788314 
…-UI-React into react-16.3
test(Dropdown): disable some tests
b4844a7 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
@layershifter layershifter mentioned this pull request Aug 6, 2018
Merged
Oleksandr Fediashov and others added 5 commits August 6, 2018 16:37
Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…
8d50e6d 
…React into react-16.3

Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>

# Conflicts:
#	docs/src/components/ComponentDoc/ComponentExample/renderExampleSourceCode.js
#	package.json
#	test/specs/modules/Dropdown/Dropdown-test.js
#	yarn.lock
update yarn.lock
746dd05 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
@layershifter
Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…
d2f69c3 
…React into react-16.3
@layershifter
chore(package): fix typings conflicts
ceecf00
merge master
15799e3 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
@layershifter layershifter changed the title BREAKING(package): use React 16.3 BREAKING(package): require React 16.3 Oct 3, 2018
Oleksandr Fediashov added 3 commits October 3, 2018 15:25
bump deps
806b78b 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
fix broken tests
943c849 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
fix types versions
363ef06 
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
@codecov-io
Copy link

codecov-io commented Oct 24, 2018 •
edited
Loading

Codecov Report

Merging #3032 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3032   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         169      169           
  Lines        2802     2802           
=======================================
  Hits         2800     2800           
  Misses          2        2
Impacted Files Coverage Δ
src/modules/Transition/TransitionGroup.js 100% <ø> (ø) ⬆️
src/addons/Portal/Portal.js 100% <100%> (ø) ⬆️
src/modules/Accordion/AccordionPanel.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73f7d05...959ed6a. Read the comment docs.

@layershifter layershifter merged commit 6e83af2 into master Oct 24, 2018
@layershifter layershifter deleted the react-16.3 branch November 25, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore ready for merge ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@layershifter @codecov-io